Skip to content

Add RAK WisMesh Pod variant and fix Tag LPCOMP wake on user shutdown#11049

Merged
thebentern merged 4 commits into
meshtastic:developfrom
Ethan-chen1234-zy:feature/add_rak_wismesh_pod
Jul 18, 2026
Merged

Add RAK WisMesh Pod variant and fix Tag LPCOMP wake on user shutdown#11049
thebentern merged 4 commits into
meshtastic:developfrom
Ethan-chen1234-zy:feature/add_rak_wismesh_pod

Conversation

@Ethan-chen1234-zy

@Ethan-chen1234-zy Ethan-chen1234-zy commented Jul 17, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Add [env:rak_wismesh_pod] for RAK WisMesh Pod (extends rak_wismeshtag, pin map shared).
  • Pod has no user buttons: under WISMESH_POD, skip PIN_BUTTON* and set HAS_BUTTON 0.
  • Fix Tag/Pod user shutdown / config reboot wake loop: port variant_enableBatteryLpcompWake() from #10918 so LPCOMP is enabled only for brownout-driven System OFF, not CLI/App shutdown.

Files changed

File Change
rak_wismeshtag/platformio.ini New env:rak_wismesh_pod + WISMESH_POD
rak_wismeshtag/variant.h Disable buttons when WISMESH_POD
rak_wismeshtag/variant.cpp LPCOMP wake only after low-VDD System OFF

Test plan

  • pio run -e rak_wismeshtag
  • pio run -e rak_wismesh_pod
  • Tag: App/CLI config + battery ~3.4V — no reboot loop after save/shutdown
  • Tag: low-VDD brownout still enters System OFF and can wake when battery recovers
  • Pod: no button GPIO / no phantom button events
  • Tag: button behavior unchanged

Summary by CodeRabbit

  • New Features

    • Added a new board build configuration for the RAK WisMesh Pod.
    • Updated the WisMesh Pod variant to reflect that hardware buttons are not present.
    • Enabled low-battery/low-VDD wake behavior after the device enters System OFF.

  • Bug Fixes

    • Improved low-voltage brownout handling to ensure wake behavior works correctly following forced System OFF.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 59ba341f-7975-4add-a372-66b54ec1a4b4

📥 Commits

Reviewing files that changed from the base of the PR and between 485579d and b0fb9e1.

📒 Files selected for processing (1)
  • variants/nrf52840/rak_wismeshtag/platformio.ini
📝 Walkthrough

Walkthrough

Adds a WisMesh Pod PlatformIO environment, disables button definitions for that variant, and tracks low-VDD System OFF entry to control battery LPCOMP wake behavior.

Changes

WisMesh Pod support

Layer / File(s) Summary
WisMesh Pod build and button configuration
variants/nrf52840/rak_wismeshtag/platformio.ini, variants/nrf52840/rak_wismeshtag/variant.h		 Adds the rak_wismesh_pod environment with the WISMESH_POD flag and defines the variant as having no buttons.
Low-VDD System OFF wake tracking
variants/nrf52840/rak_wismeshtag/variant.cpp		 Records when low VDD triggers System OFF and exposes that state through variant_enableBatteryLpcompWake().

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: thebentern

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main changes: a new RAK WisMesh Pod variant and LPCOMP wake behavior fix.
Description check ✅ Passed The description includes a summary, file-by-file impact, and a test plan, covering the template's main required information.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Flash this PR in the Web Flasher

firmware commit boards expires

Warning

This is an automated, unreviewed CI test build. Back up your device configuration
before flashing, and only flash devices you are able to recover.

Supported boards built by this PR (30)
Device Board Platform
Crowpanel Adv 3.5 TFT elecrow-adv-35-tft esp32-s3
Heltec HT62 heltec-ht62-esp32c3-sx1262 esp32-c3
Heltec Mesh Node 096 heltec-mesh-node-t096 nrf52840
Heltec Mesh Node T1 heltec-mesh-node-t1 nrf52840
Heltec Mesh Node T114 heltec-mesh-node-t114 nrf52840
Heltec V3 heltec-v3 esp32-s3
Heltec V4 heltec-v4 esp32-s3
Meshnology W10 meshnology_w10 esp32-s3
Raspberry Pi Pico pico rp2040
Raspberry Pi Pico W picow rp2040
RAK WisMesh Pocket V3 rak_wismesh_pocket nrf52840
RAK WisMesh Pod rak_wismesh_pod nrf52840
RAK WisMesh Repeater Mini V2 rak_wismesh_repeater_mini nrf52840
RAK WisMesh Tag rak_wismeshtag nrf52840
RAK WisBlock 11200 rak11200 esp32
RAK WisBlock 11310 rak11310 rp2040
RAK3312 rak3312 esp32-s3
RAK WisBlock 4631 rak4631 nrf52840
Seeed SenseCAP Mesh-Tracker-X1 seeed_mesh_tracker_X1 nrf52840
Seeed Wio Tracker L1 seeed_wio_tracker_L1 nrf52840
Seeed Xiao NRF52840 Kit seeed_xiao_nrf52840_kit nrf52840
Seeed Xiao ESP32-S3 seeed-xiao-s3 esp32-s3
Station G2 station-g2 esp32-s3
Station G3 station-g3 esp32-s3
LILYGO T-Deck t-deck-tft esp32-s3
LILYGO T-Echo t-echo nrf52840
LILYGO T-Echo Plus t-echo-plus nrf52840
LILYGO T-Impulse Plus t-impulse-plus nrf52840
LilyGo T3-C6 tlora-c6 esp32-c6
Seeed SenseCAP T1000-E tracker-t1000-e nrf52840

Build artifacts expire on 2026-08-16. Updated for 588c8d3.

@thebentern thebentern added the hardware-support Hardware related: new devices or modules, problems specific to hardware label Jul 17, 2026
@thebentern

thebentern commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@Ethan-chen1234-zy please run trunk fmt

@Ethan-chen1234-zy @cursoragent
chore: trunk fmt - replace Unicode em-dash in Pod comment
b0fb9e1 
Co-authored-by: Cursor <cursoragent@cursor.com>
@Ethan-chen1234-zy

Ethan-chen1234-zy commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Done — ran trunk fmt. Replaced the Unicode em-dash in the Pod platformio.ini comment with ASCII -.

@thebentern
thebentern merged commit 37fdbb4 into meshtastic:develop Jul 18, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hardware-support Hardware related: new devices or modules, problems specific to hardware

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ethan-chen1234-zy @thebentern